Repository navigation
feat(recall): make timeout configurable - #58
Conversation
51f483c to
05bb603
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Malformed timeout values with numeric prefixes are silently accepted instead of warning and falling back.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds configurable recall timeouts while retaining the 10-second default.
Changes:
- Adds config-file and environment-variable support.
- Applies the timeout to auto-recall and the recall tool.
- Adds tests and documentation.
File summaries
| File | Description |
|---|---|
src/config.ts |
Defines, loads, and validates the timeout. |
src/client.ts |
Uses the configured recall timeout. |
tests/client.test.ts |
Tests client timeout behavior. |
tests/config.test.ts |
Tests configuration loading and validation. |
tests/fixtures.ts |
Updates shared fixtures and environment cleanup. |
tests/recall.test.ts |
Tests auto-recall timeout behavior. |
tests/tools.test.ts |
Tests recall-tool timeout behavior. |
README.md |
Adds configuration guidance. |
docs/reference.md |
Documents the setting and environment variable. |
CHANGELOG.md |
Records the feature under Pending. |
AGENTFEEDBACK.md |
Records changelog placement guidance. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
05bb603 to
d4e03d5
Compare
|
@codex review |
There was a problem hiding this comment.
🟡 Changes recommended
Timeout values exceeding the JavaScript timer range are accepted but can cause immediate timeouts.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Balanced
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4e03d546c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add recallTimeoutMs for auto-recall and the recall tool while preserving the existing 10-second default. Recall failures continue without retries or degraded fallback behavior. Fixes #52
d4e03d5 to
129363f
Compare
Add recallTimeoutMs for auto-recall and the recall tool while preserving the existing 10-second default. Recall failures continue without retries or degraded fallback behavior.