Skip to content

[Syntax]: Adopt gamecoe's naming convention - #8

Merged
nircoe merged 9 commits into
mainfrom
nircoe/main/align_gamecoe_syntax
Sep 29, 2026
Merged

nircoe merged 9 commits into
mainfrom
nircoe/main/align_gamecoe_syntax

Conversation

@nircoe

@nircoe nircoe commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

logcoe used camelCase/PascalCase/s_-prefixed naming and a LoggerImpl class for its internal state.
This renames everything to gamecoe's snake_case/g_-prefix convention and replaces LoggerImpl with free functions over anonymous-namespace globals.

  • Prefix cmake/utils.cmake's functions with logcoe_
  • Rename the public API to snake_case (LogLevel to log_level, function and parameter names)
  • Replace LoggerImpl with free functions over anonymous-namespace globals, wrapped in internal::
  • Update tests to the renamed API
  • Update README.md, CONTRIBUTING.md, and ARCHITECTURE.md for the renamed API and structure, and document the snake_case/g_-prefix convention
  • Fix data races in flush() and the default log source lookup by holding the mutex for their full duration
  • Fix an integer underflow in shutdown() when called without a prior initialize()

@nircoe nircoe self-assigned this Sep 28, 2026
@nircoe
nircoe marked this pull request as ready for review September 29, 2026 19:38
@nircoe
nircoe merged commit ef6f313 into main Sep 29, 2026
8 checks passed
@nircoe
nircoe deleted the nircoe/main/align_gamecoe_syntax branch September 29, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant