SHORTEST_PATHS_ECMP on Core EQUAL_BALANCED; netgraph-core>=0.10.0 (0.23.1) - #112
Merged
Merged
Conversation
…23.1) Core 0.10.0 folds the load-blind next-hop set into EQUAL_BALANCED and removes EQUAL_BALANCED_FIXED. The IGP ECMP preset and the fan-out path in the cached engine map to EQUAL_BALANCED; placement is unchanged except max_flow(EQUAL_BALANCED, shortest_path=False, require_capacity=False), which now places once. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EQUAL_BALANCEDand removesEQUAL_BALANCED_FIXED.SHORTEST_PATHS_ECMPand the combine fan-out path now map toEQUAL_BALANCED; minimum Core raised to 0.10.0; version 0.23.1.max_flow(flow_placement=EQUAL_BALANCED, shortest_path=False, require_capacity=False), which filled the cost-only DAG in several passes and now places once.Test plan
bash .superset/workspace.sh checkagainst Core 0.10.0: 1274 tests passmax_flowcase and a second placement on a stale DAG🤖 Generated with Claude Code