EQUAL_BALANCED keeps the topology next-hop set; remove EQUAL_BALANCED_FIXED (0.10.0) - #10
Merged
Merged
Conversation
…_FIXED (0.10.0) EQUAL_BALANCED built its split set from the DAG edges that still had residual, so re-placing on a DAG that contained a member filled by an earlier placement silently re-hashed over the remaining members. A forwarding table does not react to load: the split set is now every DAG edge with capacity and a full member drives the single admission scale to 0. Progression past a full member comes from a residual-aware SPF, which place_max_flow and FlowPolicy already do. EQUAL_BALANCED_FIXED (0.9.0) carried exactly this behaviour as a separate mode and is removed; EQUAL_BALANCED_LOSSY is now value 3. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EQUAL_BALANCEDbuilt its split set from the DAG edges that still had residual, so re-placing on a DAG that contained a member filled by an earlier placement silently re-hashed over the remaining members. A forwarding table does not react to load: the split set is now every DAG edge with capacity, and a full member drives the single admission scale to 0.place_max_flowandFlowPolicyalready do, so every documented path is unchanged. The one observable change isplace_max_flow(EQUAL_BALANCED, require_capacity=False, shortest_path=False), which now places once instead of filling a cost-only DAG in several passes.EQUAL_BALANCED_FIXED(0.9.0) carried exactly this behaviour as a separate mode and is removed;EQUAL_BALANCED_LOSSYis now value 3. Version 0.10.0.Test plan
make cpp-test: 170/170make linttests/py: all pass on a locally built wheelv0.10.0🤖 Generated with Claude Code