Repository navigation
Release 3.0.2 patch: correct unsupported Kerberos fallback and documentation - #96
Open
netanelcyber wants to merge 4 commits into
Open
netanelcyber wants to merge 4 commits into
netanelcyber wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing release branch still attempts to obtain a KRBTGT key from LDAP
unicodePwd, which AD never returns in a search. This patch removes that unsupported path: failed/refused collection retainssuccess=False, no key and no generated ticket. The legacy SPN formatter is documented as account/SPN metadata. WinRM report tests now read the UTF-8 artifacts explicitly, fixing Windows locale-dependent decoding failures.Carries the approved core and documentation corrections from #95 onto the current 3.0.2 release tree, preserving its WinRM profile and existing APIs. Replaces unsupported escalation/CVE claims with evidence limits and remediation, documents all eight profiles through
python -m adpentest --diagnostic-tools all, and corrects the package documentation URL.Publication uses the existing PyPI secret through the standard build workflow. Only a push to the exact
release/pypi-3.0.2branch adds an automatic upload trigger, guarded by version consistency, compilation, the regression suite and strict Twine checks. The preparation branch does not publish. Release/manual publication events remain supported.Validation:
d3720b78ca757a5746d5aac5c7aa159da3aad28b.release/pypi-3.0.2.No live AD/KDC authentication was performed.