Repository navigation
test: the lost-link test waits for the armed marker instead of fixed timers - #149
Merged
Merged
Conversation
…armed marker The fake ssh in `lost` mode killed the relay on a fixed one-second timer. When the relay took longer than that to start, connect and forward the marker (a freshly built binary pays about half a second on its first exec, more under a full gates run), the client saw no byte and rightly reported an ssh failure. The fake now waits for the client to see the marker, so the test always proves what its name says. Closes #141 Co-Authored-By: Claude <noreply@anthropic.com>
…he marker, not for a fixed 3 s Part of #141 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141
client::remote_tests::a_link_that_dies_after_the_arming_is_a_lossfailed now and then under a loaded machine. The fake ssh cut the relay after a fixed second, and the stand-in server closed after a fixed three; when a fresh binary took longer than that to start and pass the armed marker on, the client saw "ssh failed" instead of a lost link. Only the test was wrong: the client decides by what it really received.armedfile when it sees it).No product code changes. Checks:
scripts/gates.shpasses; the failure was reproduced 3 of 3 times under load before and 0 of 50 after; an audit passed, and its note about the remaining three-second timer is the second commit.🤖 Generated with Claude Code