Repository navigation
Consumable cures, timed item buffs and CANCEL_ITEM_EFFECT - #514
Merged
Merged
Conversation
Item specs now carry their duration, the stats they raise and the diseases they cure. USE_ITEM cures those diseases (All Cure and the single cures) and gives the stats as a buff of id -item_id for the spec's time, which the client lists with the item's icon. CANCEL_ITEM_EFFECT (0x49) ends it, and HeavenClient now sends it when an item buff's icon is right-clicked, as v83 does (FUN_0045b9fc / FUN_00a096af).
neeerp
force-pushed
the
v83/consumables
branch
from
October 17, 2026 23:26
0b4e5a3 to
6c8b9d9
Compare
neeerp
added this pull request to stack #515
October 17, 2026 23:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USE_ITEM applied only HP and MP. The cures (All Cure and the single cures) and the timed stat pills and elixirs did nothing, and an item buff couldn't be cancelled.
What changed
time(ms), the stats they raise (pad,pdd,mad,mdd,acc,eva,speed,jump) and the diseases they cure (poison,darkness,weakness,seal,curse).-item_id, which the client lists with the item's icon.FUN_0045b9fc,FUN_00a096af); before, it sent nothing for item buffs.Not covered
0x10fc); HeavenClient doesn't track morphs.*Ratevariants,mhpR, booster, berserk,thaw, and the meso and EXP bonuses.Verification
item_buffs: GIVE_BUFF (-2002004, 5, 180000); CANCEL_ITEM_EFFECT ends it, and a second cancel does nothing.harnessctl test) passes, as do all 68 client tests (ctest) in a debug build. Each layer of the stack passescargo fmt --checkand the workspace unit tests, and builds the harness tests.Reviewed with sol-loop: 2 rounds with gpt-6.1-sol on high.
Stacked on #513