Repository navigation
Skill books, fame and blocked map/server notices - #507
Merged
Merged
Conversation
Merged
…v83 30/37/51) 30 sets a tab's slot count and refreshes the item window, 37 answers the pending skill request, 51 shows the SkillBook glow on the user (front and back layers) and, for the local player, the Enchant sound and the v83 chat line.
…ULT 0x33 The server reads a book's info/skill, masterLevel, reqSkillLevel and success, takes the skill of the reader's job, spends the book and rolls its success; HeavenClient sends 0x52 for 228/229 items (v83 FUN_00a0a1b2).
HeavenClient answers the pending move and shows v83's reason in chat or a notice. The server refuses a portal it can't resolve with BLOCKED_MAP instead of disconnecting, and channel or cash shop refusals with BLOCKED_SERVER.
Server: GiveFameHandler (level 15, not self), fame_log with the day and 30-day rules, the field routes to the target on the giver's map, the target changes its fame and answers both sides; a miss is forgotten. HC: fame buttons per v83 (FUN_00a23eb5: on-map check, 5 minute cooldown), FameResponseHandler lines, char info fame update. Co-Authored-By: Claude <noreply@anthropic.com>
neeerp
force-pushed
the
v83/books-fame-notices
branch
from
October 17, 2026 23:26
21c1990 to
14cc85c
Compare
neeerp
added this pull request to stack #515
October 17, 2026 23:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill and mastery books, fame, and the blocked map/server notices, plus three client handlers they rely on.
What changed
FUN_00a0a1b2). The server reads the book's skills, master level, required skill level and success. It takes the skill of the reader's job, spends the book and rolls, and answers with SKILL_LEARN_ITEM_RESULT (0x33).fame_log;FUN_00a23eb5: on-map check, 5 minute cooldown).Verification
skill_booksandfame; new client testfame_cooldown.Reviewed with sol-loop: 2 rounds with gpt-6.1-sol on high.
Stacked on #506