Repository navigation
Job buffs, foreign buffs, Shadow Partner and party buffs - #505
Merged
Merged
Conversation
Server: buff skills give their level's stats plus their own (Booster, Combo, charges, Hyper Body, Maple Warrior, Dark Sight, Shadow Partner, ...), with MP, cooldown and item costs. GIVE_BUFF carries every stat in the client's bit order with the exact tail. The stats others see go out as GIVE/CANCEL_FOREIGN_BUFF (0xC7/0xC8) on use, cancel, expiry and death, and in SPAWN_PLAYER. Damage caps count attack buffs; Shadow Partner doubles a shot's lines and Soul Arrow needs no arrows. A player leaving a field is shown before mob/NPC control passes on. HC: BuffParser reads the flags in the v83 decode order (FUN_00781d0e) and the remote encoding (FUN_00788156, two-state blocks). Buffstat::by_bit replaces the unordered maps. New 199/200 handlers and the spawn block keep remote buffs on OtherChar. Harness: strict packet loops skip NPC control (0x103).
Locally a ranged attack with Shadow Partner (not Taunt or Vampire) has twice the hits, at most 15, and throws its bullets again from 30 px behind the user, below the first set. Other users' shots read their Shadow Partner foreign buff: twice the bullets and shown hits, the client's start choice by mob index, and a miss's ends 30 px short.
USE_SKILL's party mask now reaches the members it names: the directory maps slot bits to party members on the caster's map, and each applies the buffs (or Heal's share) when alive and within the skill's lt/rb plus 100 px, with user effect 2 showing the skill's affected animation. HC plays that effect on 0xC6 and 0xCE type 2 instead of the use effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job buff skills now give their full stats, the stats others see go out as foreign buffs, and party skills reach the party.
What changed
BuffParserreads both encodings in v83's order (FUN_00781d0e,FUN_00788156) and keeps remote buffs onOtherChar.Not covered
Verification
Reviewed with sol-loop: 2 rounds with gpt-6.1-sol on high.
Stacked on #504