Skip to content

Fix #202, Adds invalid CC error branch - #203

Merged
chillfig merged 1 commit into
nasa:devfrom
chillfig:fix-202-add-invalid-ground-CC
Sep 15, 2026
Merged

chillfig merged 1 commit into
nasa:devfrom
chillfig:fix-202-add-invalid-ground-CC

Conversation

@chillfig

@chillfig chillfig commented Sep 14, 2026

Copy link
Copy Markdown
Member

name: FSW Code Change
about: Flight Software code changes
labels: fsw

Description of Change

  • Fixes Add invalid CC error branch #202 , CI_LAB previously ignored unrecognized ground command function codes without incrementing CommandErrorCounter or emitting an error event. This adds a CI_LAB_CC_ERR_EID event and updates the default ground-command dispatch path to report the invalid MID/CC and increment the command error counter

Linked Issue

Closes #202

Requirements Impact

  • Requirement ID(s):
  • Requirements updated as necessary
  • Existing requirements are still satisfied by this change

Testing Evidence

Sent function code 99. Valid options are 0 and 1.

Screenshot 2026-09-14 at 2 00 44 PM

Unit Tests (UT Assert)

N/A

COSMOS Test Suite

N/A

Areas of Expertise Touched

  • ASTRO
  • CI/CD
  • COSMOS
  • Cybersecurity
  • Docker
  • EDS
  • Git
  • PSPs
  • SBN
  • SMP
  • Tables
  • TSN
  • Unit Tests
  • Other

Author Checklist

  • Linked GitHub issue is referenced above
  • Code has been formatted with .clang-format
  • Static analysis workflows ran and passed
  • Unit tests (UT Assert) updated/added to cover code changes
  • Unit test workflows ran and passed
  • COSMOS test suite was run; tests updated/added if relevant changes were made
  • [] Requirements have been reviewed; updated or confirmed still satisfied (see above)
  • Testing evidence is included above
  • Self-review of the diff completed

Reviewer Checklist

  • Code logic is correct and matches the stated intent
  • Code is readable, maintainable, and follows project conventions (ask your lead if you are unsure of where to find these conventions)
  • .clang-format has been applied
  • Static analysis results reviewed and acceptable
  • The change has been exercised by the unit tests (not just that tests pass — the new/changed code paths are actually covered)
  • COSMOS test suite was executed against this change and results reviewed (or confirmed N/A with justification)
  • Reviewer has independently verified the change behaves as described (e.g., by running the tests locally, reviewing CI output in detail, or performing additional ad-hoc testing as warranted)
  • Memory safety reviewed (allocation, bounds, lifetime, stack usage)
  • Requirements impact reviewed and appropriate
  • Error handling is appropriate
  • Appropriate Expert areas have been reviewed

Reviewer Testing Notes

@chillfig chillfig self-assigned this Sep 14, 2026
@chillfig chillfig added the enhancement New feature or request label Sep 14, 2026
@Cameron-Sykes

Copy link
Copy Markdown

All unit tests pass
image

@chillfig
chillfig merged commit e3c4d62 into nasa:dev Sep 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add invalid CC error branch

4 participants