Validate SA rekey encryption key state - #542
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #533.
Reject SA rekey requests unless the new encryption key exists and is
KEY_ACTIVEbefore mutating the SA.The current
devimplementation ofsa_rekeyparses a new encryption key ID (ekid), so this change validates that key before assigning it or transitioning the SA toSA_KEYED. The existing nominal rekey fixture now sets its key state explicitly to make the precondition visible.A regression test verifies that a deactivated key returns
CRYPTO_LIB_ERR_KEY_STATE_INVALID, leaves the existing key ID unchanged, and keeps the SA inSA_UNKEYED.Validation:
EP_SA_MGMT.SA_REKEY_REJECTS_INACTIVE_KEYEP_SA_MGMT.SA_6_REKEY_133git diff --checkFocused tests were built and run with CryptoLib's internal key/SA/MC configuration and Homebrew libgcrypt on macOS.