Skip to content

Fix aux channels not decaying #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathesoncalum merged 1 commit into from
Sep 16, 2026
Merged

Fix aux channels not decaying #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions framework/audio/engine/internal/mixer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ using namespace muse::audio::engine;

constexpr size_t MIN_TRACK_COUNT_FOR_MULTITHREADING = 2;

static bool isChainSilent(const TrackChainPtr& chain)
{
if (auto signal = chain->signal()) {
return signal->isSilent();
}
return false;
}

Mixer::~Mixer()
{
ONLY_AUDIO_MAIN_OR_ENGINE_THREAD;
Expand Down Expand Up @@ -151,11 +159,9 @@ void Mixer::process(float* outBuffer, samples_t samplesPerChannel)
}

//! NOTE If the signal is silent, do not write to the output buffer
// and don't process aux tracks
if (auto signal = t.chain->signal()) {
if (signal->isSilent()) {
continue;
}
//! or the aux buffers
if (isChainSilent(t.chain)) {
continue;
}

mixOutputFromChannel(outBuffer, t.buffer.data(), outBufferSize);
Expand Down Expand Up @@ -307,18 +313,18 @@ void Mixer::processAuxChannels(float* buffer, samples_t samplesPerChannel)
const size_t outBufferSize = samplesPerChannel * m_outputSpec.audioChannelCount;

for (TrackData& aux : m_auxTracks) {
if (!aux.processed) {
//! NOTE Process when the aux received a signal this block (aux.processed) and/or if
//! it's not yet silent (e.g. reverb is still ringing out)
if (!aux.processed && isChainSilent(aux.chain)) {
continue;
}

float* auxBuffer = aux.buffer.data();
aux.chain->process(auxBuffer, samplesPerChannel);

//! NOTE If the signal is silent, do not write to the output buffer
if (auto signal = aux.chain->signal()) {
if (!signal->isSilent()) {
mixOutputFromChannel(buffer, auxBuffer, outBufferSize);
}
if (!isChainSilent(aux.chain)) {
mixOutputFromChannel(buffer, auxBuffer, outBufferSize);
}
}
}
Expand Down