Skip to content

Fix an assert when trimming utf8 strings #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kryksyh wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

Fix an assert when trimming utf8 strings #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions framework/global/stringutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,18 +152,16 @@ std::string muse::strings::join(const std::vector<std::string>& strs, const std:
}
}

static constexpr const char* TRIM_CHARS = " \t\n\v\f\r";

void muse::strings::ltrim(std::string& s)
{
s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](unsigned char ch) {
return !std::isspace(ch);
}));
s.erase(0, s.find_first_not_of(TRIM_CHARS));
}

void muse::strings::rtrim(std::string& s)
{
s.erase(std::find_if(s.rbegin(), s.rend(), [](int ch) {
return !std::isspace(ch);
}).base(), s.end());
s.erase(s.find_last_not_of(TRIM_CHARS) + 1);
}

void muse::strings::trim(std::string& s)
Expand Down