Skip to content

Let the application own the MUSE_COMPILE_USE_PCH option #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luapmartin wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

Let the application own the MUSE_COMPILE_USE_PCH option #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2460ca8
remove MUSE_COMPILE_USE_PCH declaration, the application owns it
luapmartin Aug 28, 2026
9b35bd4
standalone build: declare the PCH and unity options OFF to keep CI st…
luapmartin Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@ set(MUSE_APP_BUILD_MODE "dev" CACHE STRING "Build mode")
# - testing - for testing versions (alpha, beta, RC)
# - release - for stable release builds

# Consumer applications own these options and must declare them on their side.
# The standalone framework build is the application here, and deliberately
# builds with PCH and unity OFF: every source stays self-contained (see #256),
# so CI catches missing includes and Qt module links that PCH or unity batches
# would mask.
option(MUSE_COMPILE_USE_PCH "Use precompiled headers." OFF)
option(MUSE_COMPILE_USE_UNITY "Use unity build." OFF)

include(${MUSE_FRAMEWORK_SRC_PATH}/cmake/MuseDeclareOptions.cmake)

###########################################
Expand Down
1 change: 0 additions & 1 deletion framework/cmake/MuseDeclareOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ option(MUSE_CONFIGURATION_IS_WEB "Configuration is web" OFF)

# === Build options ===
option(MUSE_COMPILE_ASAN "Enable Address Sanitizer" OFF)
option(MUSE_COMPILE_USE_PCH "Use precompiled headers." ON)

# === Debug options ===
option(MUSE_COMPILE_STRING_DEBUG_HACK "Enable string debug hack (only clang)" ON)
Expand Down