Skip to content

Fix offset spinboxes not updated #34868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathesoncalum merged 1 commit into from
Sep 17, 2026
+7 −3
Merged

Fix offset spinboxes not updated #34868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ropertiespanel/qml/MuseScore/PropertiesPanel/general/appearance/appearancesettingsmodel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ class AppearanceSettingsModel : public PropertiesPanelAbstractModel

bool isVerticalOffsetAvailable() const;

void onNotationChanged(const mu::engraving::PropertyIdSet& changedPropertyIdSet,
const mu::engraving::StyleIdSet& changedStyleIdSet) override;

public slots:
void setIsSnappedToGrid(bool isSnapped);
void setIsVerticalOffsetAvailable(bool isAvailable);
Expand All @@ -81,8 +84,6 @@ public slots:
void isVerticalOffsetAvailableChanged(bool isVerticalOffsetAvailable);

private:
void onNotationChanged(const mu::engraving::PropertyIdSet& changedPropertyIdSet,
const mu::engraving::StyleIdSet& changedStyleIdSet) override;
void loadProperties(const mu::engraving::PropertyIdSet& allowedPropertyIdSet);

void updateIsVerticalOffsetAvailable();
Expand Down
5 changes: 4 additions & 1 deletion src/propertiespanel/qml/MuseScore/PropertiesPanel/general/generalsettingsmodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,12 @@ void GeneralSettingsModel::loadProperties()
updateAreGeneralPropertiesAvailable();
}

void GeneralSettingsModel::onNotationChanged(const PropertyIdSet& changedPropertyIdSet, const StyleIdSet&)
void GeneralSettingsModel::onNotationChanged(const PropertyIdSet& changedPropertyIdSet, const StyleIdSet& changedStyleIdSet)
{
loadProperties(changedPropertyIdSet);

m_appearanceSettingsModel->onNotationChanged(changedPropertyIdSet, changedStyleIdSet);
m_playbackProxyModel->onNotationChanged(changedPropertyIdSet, changedStyleIdSet);
}

void GeneralSettingsModel::loadProperties(const mu::engraving::PropertyIdSet& propertyIdSet)
Expand Down
Loading