Add MatchingTimelines to Model - #68
Open
LourensVeen wants to merge 3 commits into
Open
LourensVeen wants to merge 3 commits into
LourensVeen wants to merge 3 commits into
Conversation
IrisvdWerf
approved these changes
Sep 21, 2026
IrisvdWerf
reviewed
Sep 22, 2026
LourensVeen
force-pushed
the
timeline_equivalence
branch
from
September 23, 2026 04:48
885c52a to
015bfc8
Compare
LourensVeen
added this pull request to stack #71
September 23, 2026 04:53
LourensVeen
force-pushed
the
timeline_equivalence
branch
from
September 23, 2026 06:53
0a6b7bf to
cdf5f9c
Compare
LourensVeen
force-pushed
the
timeline_equivalence
branch
from
September 23, 2026 08:53
cc2bf93 to
1d4c558
Compare
IrisvdWerf
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
MatchingTimelinesclass and adds it toModel, so that we can express which timelines on which components match and can therefore be connected. See multiscale/muscle3#417This adds the matching timelines to the
Modelclass in a logical spot, which is not at the end and therefore not backwards compatible. That didn't seem to annoy the users much when we broke API compatibility for v0.2, so I think it's okay and better than building up technical debt and then having to go to v0.3, but I may be wrong.