Repository navigation
Conversation
{{ message }}
Repository navigation
This repository is temporarily unavailable.
The backend storage is temporarily offline. Usually this means the storage server is undergoing maintenance. Please contact support if the problem persists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
/,/oauthand/authorization. The Backbone index and authorization views are dead code.emailFirstRoutesandsimpleRoutesflags are on in stage and prod, so they only keep dead code alive.This pull request
(/),authorization(/)andoauth(/)routes inrouter.jstocreateReactViewHandler. The(/)route keepsredirect_to. The routes stay because remaining Backbone views navigate to/.views/index.js,views/authorization.js,views/ready.js, the index and ready templates, and the partialsbrand-messaging,coppa-age-inputandthird-party-auth.lib/email-domain-validator.js. The server routevalidate-email-domain.jsstays, because fxa-settings calls it.test_start.js. The router spec now usesPermissionsViewinstead ofReadyViewfor the string-load tests.isPrimaryEmailinverification-reason-mixin.js,PRIMARY_EMAIL_VERIFIEDinverification-reasons.ts, and_isVerificationInMobileSafariinapp-start.js.featureFlagOn: trueonemailFirstRoutesandsimpleRoutesinreact-app/index.js.fullProdRollout: truestays.configuration.js,local.json-distandreact-app/types.ts. RemovesshowReactAppfrombeta-settings.jsand fromconfig.tsin fxa-settings (type and default).emailFirstRoutesclause fromcookiesDisabled.spec.ts.pocket-migration-mixin.jsthat names the deletedmonitor-client-mixin.Issue that this pull request solves
Closes: FXA-14378
Checklist
Put an
xin the boxes that applyHow to review (Optional)
router.js,react-app/index.js, and the config removals.router.js. A deleted module that is still in use would show only at run time.Screenshots (Optional)
No UI change.
Other information (Optional)
Local checks, on the local stack:
tests/signin/signIn.spec.ts("login as an existing user") andtests/misc/cookiesDisabled.spec.ts.GET /,/oauthand/authorizationon port 3030 return 200.npx nx build fxa-content-server: PASS.npx nx lint fxa-content-server: PASS. This target lints.jsfiles only..tsfiles in fxa-content-server: FAIL with a parser error. The package eslint config has no TypeScript parser. The error also occurs onorigin/main.Not run here:
tests/oauth/*. These need 123done, so CI only.tests/misc,tests/signinand the signup specs.Follow-ups:
.circleci/config.ymland the Cloudops config still setREACT_CONVERSION_EMAIL_FIRST_ROUTESandREACT_CONVERSION_SIMPLE_ROUTES. Convict ignores env vars that have no schema entry, so this is safe. Remove them in a follow-up.get-index.jsstill readsemailFirstRoutes.featureFlagOn, which is always true now. I left it as is.misc-cookiesDisabled-cooki-85178--with-localStorage-disabled-local.webm
misc-cookiesDisabled-cooki-f7f25--with-localStorage-disabled-local.webm
signin-signIn-severity-2-s-e7b7a-n-login-as-an-existing-user-local.webm