Repository navigation
Conversation
Because: - The v2 pairing specs ran, and failed, on a stack that serves pairing.version 1. This commit: - Skips the v2 pairing flow tests unless the stack serves pairing.version 2. - Adds the same skip to the env-gated Android and iOS v2 specs. Closes FXA-14637
dschom
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
pairing.version1.pairChoice.spec.tsalready does.This pull request
beforeAllinpairingFlowV2.spec.ts, withbrowserandtarget, aspairChoice.spec.tsdoes. Each test skips when the version is not 2.beforeEachofpairingFlowV2Android.spec.tsandpairingFlowV2iOS.spec.ts, after the env and Nightly gates. Both skip the same way.pairingUnsupported.spec.tsis unchanged. It does not read the pairing config.Issue that this pull request solves
Closes: FXA-14637
Checklist
Put an
xin the boxes that applyHow to review (Optional)
beforeAllandbeforeEachinpairingFlowV2.spec.ts.pairingFlowV2.spec.ts, then the Android and iOS specs.Screenshots (Optional)
Not applicable. No user interface change.
Other information (Optional)
Local run on a stack that serves version 1.
FIREFOX_BINARY=/bin/truegets past the Nightly gate.npx playwright test tests/pairing/pairingFlowV2.spec.ts --project=local: 3 tests skipped,Needs the stack to serve config.pairing.version=2 (serving 1). The same run on the old spec tried to launch Marionette and failed withMarionette port 2829 not available after 30000ms.pairChoice.spec.ts: 4 passed, 3 skipped (its own v2 tests).tscon the changed files: pass.tscreports errors on main inlib/testAccountTracker.ts, not in the changed files.