Repository navigation
Conversation
dschom
marked this pull request as ready for review
October 9, 2026 01:26
Because: - Pairing signs a device in to Sync, so a browser that already holds a verified account has nothing to pair. - The v2 supplicant flow completed anyway, with no warning to the user. This commit: - Routes a signed-in supplicant to the pairing dead-end screen before the channel opens. - Adds a signed_in reason and copy to the TimeoutAndCancel page. - Lists the new reason in the Glean timeout_view extra description. Closes FXA-14479
bcolsson
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
/pairto the pairing dead-end screen before the channel opens, so the Connect card is never shown.signed_inreason toTimeoutAndCancelwith new Fluent copy telling the user to sign out and retry, plus a Storybook story.dtm_mobile.timeout_viewextra description.Issue that this pull request solves
Closes: FXA-14479
Checklist
Put an
xin the boxes that applyHow to review (Optional)
pages/Pair/Index/index.tsx(the gate),pages/Pair2/Supplicant/TimeoutAndCancel/index.tsx(copy)en.ftl, then testsScreenshots (Optional)
FXA-14479 — mobile dead-end screen,
signed_inreason (Storybook, this branch)Other information (Optional)