Repository navigation
Conversation
fxa-agent
Bot
force-pushed
the
fxa-14689
branch
from
October 8, 2026 11:45
c6548cd to
002bc33
Compare
Because: - The WAF blocked untrusted relier requests on stage, as they had no fxa-ci header. - In pairAttribution, Firefox loaded about:preferences on pair_preferences, which raced page.goto. This commit: - Adds the untrustedRelierUrl host to fxaDomains in waf.ts. - Drops the pair_preferences WebChannel message in pairAttribution before Continue. - Waits for the dropped message, then runs the goto. Closes FXA-14689
vbudhram
approved these changes
Oct 9, 2026
vbudhram
left a comment
vbudhram
left a comment
Contributor
There was a problem hiding this comment.
Verified this against stage and tests passed 10/10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
fxa-ciheader. The WAF challenge page blocked theuntrustedRelierSignintests.pairAttributiontest, Firefox handlesfxaccounts:pair_preferencesby loadingabout:preferencesin the same tab. That navigation raced the test'spage.goto, and the test failed at the 120 s timeout.This pull request
target.untrustedRelierUrltofxaDomainsinwaf.ts. Requests to the untrusted relier, and its redirect to/authorization, now get the header.window.dispatchEventinpairAttribution.spec.tsbefore the Continue click. The wrapper drops thefxaccounts:pair_preferencesWebChannel message and records that the page sent it.goto. Firefox never starts its own navigation, so there is no race.Issue that this pull request solves
Closes: FXA-14689
Checklist
Put an
xin the boxes that applyHow to review (Optional)
page.evaluatestub inpairAttribution.spec.ts.waf.ts, thenpairAttribution.spec.ts.Screenshots (Optional)
No UI change.
Other information (Optional)
Testing
--repeat-each=5 --retries=0:pairAttribution.spec.tsanduntrustedRelierSignin.spec.ts, 35 of 35 passed.untrustedRelierSignin.spec.tsfailed 4 of 5 tests on stage.pairAttributiongoto race caused 12 hard fails and 12 flaky runs in 73 jobs.Known separate issue. On a slow stage response, sign-in can send the user from
/pairback to the password page./pairasks Firefox forfxa_statusbefore Firefox finishesoauth_login. This is a product race, not a test race. It will get its own ticket and PR.