Fix failure to apply bugzilla.create_bug action - #6758
Open
ayoubdiourin7 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Verified: filing a bug without the is_markdown field succeeds : |
suhaibmujahid
approved these changes
Sep 2, 2026
Comment on lines
204
to
216
| extra: Annotated[ | ||
| dict[str, Any] | None, | ||
| Field( | ||
| default=None, | ||
| description=( | ||
| "Optional additional fields accepted by Bugzilla's POST /bug " | ||
| "endpoint (severity, priority, keywords, whiteboard, blocks, " | ||
| "depends_on, cc, groups, op_sys, platform, assigned_to, " | ||
| "see_also, ...). Merged into the recorded body — explicit " | ||
| "top-level args win on conflict." | ||
| ), | ||
| ), | ||
| ] = None, |
Member
There was a problem hiding this comment.
These fields should be validated against what Bugzilla accepts. Similarly, for the update bug tool.
We might need to file a follow-up to consider that for future improvement.
Comment on lines
+146
to
+150
| # TEMPORARY: BMO's POST /bug rejects `is_markdown` with a 400 Bad | ||
| # Request. `create_bug` no longer records it, but this strip is needed | ||
| # to apply actions recorded before that change. Delete it once no | ||
| # pending/failed `bugzilla.create_bug` row still carries the flag. | ||
| body = {k: v for k, v in params.items() if k != "is_markdown"} |
Member
There was a problem hiding this comment.
You could drop this. I already deploy the current version of the PR, so we can use it without even landing the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_bugrecordsis_markdown: true, but BMO'sPOST /bugendpoint rejects that parameter with a400 Bad Request, causing every recorded bug filing to fail when applied.Changes
create_bugno longer recordsis_markdownin the action body.CreateBugHandlerstripsis_markdownbefore sending thePOSTrequest, allowing already-recorded actions to succeed on retry.Fixes #6752