feat(pager): give pager mode the full review controls - #647
Open
HackAttack wants to merge 1 commit into
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
@HackAttack is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
Pager mode was doing two unrelated jobs under one flag. Besides choosing the chrome, `options.pager` gated capability: every command carried a scope tag and only a dozen scrolling commands were tagged for pager, so file navigation, layout switching, the menu, help, and the theme selector were filtered out before they could run. Render guards in App then suppressed the surfaces those commands would have drawn. Dropping the scope split and the guards preserves the chrome preset without nerfing the functionality. File navigation, layout, etc. now work in pager mode. Fixes modem-dev#550 Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
HackAttack
force-pushed
the
feat/unnerf-pager
branch
from
July 30, 2026 22:01
4c23211 to
fbd14b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pager mode was doing two unrelated jobs under one flag. Besides choosing the chrome,
options.pagergated capability: every command carried a scope tag and only a dozen scrolling commands were tagged for pager, so file navigation, layout switching, the menu, help, and the theme selector were filtered out before they could run. Render guards in App then suppressed the surfaces those commands would have drawn.Dropping the scope split and the guards preserves the chrome preset without nerfing the functionality. File navigation, layout, etc. now work in pager mode.
Fixes #550