fix(runtime): free custom AVIO buffers on all exits - #3449
Merged
LauraGPT merged 1 commit intoAug 3, 2026
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
LauraGPT
approved these changes
Aug 3, 2026
LauraGPT
left a comment
Collaborator
There was a problem hiding this comment.
Validated the exact PR head together with #3448, #3449, and #3450 on current main in an isolated worktree.
- Full ONNX Runtime C++ build completed with FFmpeg enabled and AddressSanitizer instrumentation; all library, runtime binary, and OpenFST targets built successfully.
- An ASAN harness verified
AudioFramecopy construction and assignment own independent sample buffers and preserve metadata. - The same harness exercised the invalid-buffer FFmpeg cleanup path 1,000 times with leak detection enabled.
- No AddressSanitizer error or leak was reported.
The three patches touch separate ownership problems and merge cleanly as a set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Free the buffer owned by the custom
AVIOContexton every exit from the in-memory FFmpeg loader.The cleanup helper follows FFmpeg's custom-I/O example: close the format input first, free the context's current buffer, and then call
avio_context_free. It deliberately readsavio_ctx->bufferat cleanup time because libavformat may replace the original buffer while probing.Reference: https://ffmpeg.org/doxygen/trunk/avio_read_callback_8c-example.html
Why is this needed?
The error paths previously called only
avio_context_free, which does not release the caller-supplied/current AVIO buffer. Every failed in-memory decode therefore leaked the copied input buffer. The success path also freed the context structure directly instead of using the public FFmpeg cleanup API.Validation
git diff --checkAudio::FfmpegLoad(const char*, int).