Repository navigation
fix: use plain workspaces for structured matrix inputs - #225
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 68.88% 70.08% +1.20%
==========================================
Files 49 49
Lines 5904 5904
Branches 1060 1093 +33
==========================================
+ Hits 4067 4138 +71
+ Misses 1824 1753 -71
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SymmetricMatrixandDistanceMatrixkeep their class when cloned. Algorithms that use those clones as workspaces consequently mirror writes into the opposite triangle;DistanceMatrixalso resets each diagonal write to zero. For the matrix in #222,determinant()returns757.1567106010962instead of442.75, and a nonsingular distance matrix can incorrectly fail inversion as singular.Use plain
Matrixcopies for LU/QR decomposition workspaces, QR/Cholesky right-hand sides, echelon reduction, and the two-block NIPALS residuals. The public structuredclone()behavior stays intact. Regressions check factor reconstruction, determinants, inverse/solve identities, right-hand sides, row reduction, residual reconstruction, and unchanged inputs.Fixes #222.
Validation on Windows with Node.js 24.11.0:
The existing one-block NIPALS path (
Yomitted) mutates its input and retains its separate structured-residual limitation; this change only addresses the two-block path identified in #222. It does not change theclone()declaration or other algorithms.Prepared with AI assistance (OpenAI Codex).