Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Directory.GetFiles pattern - #288

Closed
mleem97 wants to merge 1 commit into
mainfrom
sentinel/lua-path-traversal-6235311121839553781
Closed

mleem97 wants to merge 1 commit into
mainfrom
sentinel/lua-path-traversal-6235311121839553781

Conversation

@mleem97

@mleem97 mleem97 commented Sep 23, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Path Traversal via unvalidated searchPattern argument in Directory.GetFiles inside GregIoLuaModule.cs's list_files function. A malicious Lua script or user could pass a pattern like ../secret/* to enumerate files outside the intended dataDir sandbox.
🎯 Impact: Allows arbitrary directory enumeration and potential exposure of sensitive file paths outside the sandbox boundaries.
πŸ”§ Fix: Added validation to the pattern argument to ensure it does not contain directory traversal characters (..) or directory separators (/, \). If such characters are detected, it throws an UnauthorizedAccessException.
βœ… Verification: Ran a local PoC confirming Directory.GetFiles resolves traversal patterns out of the base path, and executed the test suite to ensure the fix does not introduce regressions.


PR created automatically by Jules for task 6235311121839553781 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

🟒 Metrics 4 complexity · 0 duplication

Metric Results
Complexity 4
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Sep 24, 2026

Copy link
Copy Markdown
Owner Author

Superseded: same as #286 β€” current tree already blocks traversal via SanitizeSearchPattern + IsInsideSandbox. No merge needed.

@mleem97 mleem97 closed this Sep 24, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded: same as #286 β€” current tree already blocks traversal via SanitizeSearchPattern + IsInsideSandbox. No merge needed.

Understood. Acknowledging that this work is now obsolete as the current tree already blocks traversal via SanitizeSearchPattern and IsInsideSandbox. Stopping work on this task.

@mleem97
mleem97 deleted the sentinel/lua-path-traversal-6235311121839553781 branch September 25, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant