Fix metal error escaping handler - #4174
Open
zcbenz wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a kernel is committed separately from event signaling, the event would be signaled even when the kernel failed, and it is possible that the waiter of the event would be signaled before the completion handler sets the error, ends up with the error getting silently ignored.
Using the example from #4134:
While
a+bfailed due to OOM, the synchronizer event would not get the error when eval ends.This PR makes the error persistent in command encoder, until it is thrown either by event, or when users tries to use the stream.
Using the above example, with this PR while
eval(c)still does not throw, following calls will eventually receive the error.