feat(app): playground App Router pilot shell (Phase 3) - #167
Open
mkayander wants to merge 2 commits into
Open
Conversation
- Extract PlaygroundPageView shared by Pages and App pilot routes - Add /internal-marketing/[locale]/playground/[[...slug]] with pilot metadata - Share resolvePlaygroundPageSeo between gSSP and generateMetadata - Add usePlaygroundRoute bridge for slug navigation under App Router - Extend useSearchParam and usePlaygroundSlugs for next/navigation - Add playgroundRoute path helpers and vitest next/navigation mock
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mkayander
marked this pull request as ready for review
August 9, 2026 21:24
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
- Remap lastPlaygroundPath restore onto current basePath (pilot vs public) - Omit empty slug segments in buildPlaygroundPath and setCase navigation - Add remapPlaygroundPathToBase helper with unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 kickoff: adds an App Router playground pilot shell under
internal-marketing, sharing UI and SEO logic with the existing Pages/playgroundroute.Changes
App Router pilot route
/internal-marketing/[locale]/playground/[[...slug]]— full playground UI with pilotnoindexmetadata and canonical pointing at public/playgroundURLs.Shared extraction
PlaygroundPageView— client shell used by both routers.resolvePlaygroundPageSeo— shared SEO resolver for Pages gSSP and AppgenerateMetadata.App Router navigation bridge
usePlaygroundRoute— slug state + navigation for Pages and pilot paths.playgroundRoute— path parse/build helpers.usePlaygroundSlugs/useSearchParam/useMobilePlaygroundView— App Router support vianext/navigation.Review follow-ups (latest commit)
remapPlaygroundPathToBase—lastPlaygroundPathrestore remaps slug segments onto the currentbasePath(fixes pilot jumping to public URLs).buildPlaygroundPath— filters empty slug segments (fixes trailing-slash case URLs).setCase— no longer passes emptysolutionSlugsegment.Verification
pnpm lint— passpnpm test— 449 tests passStill blocked
/playgroundto App (needsnext.configi18nremoval)cacheComponents/unstable_instant