feat(app): Instant Nav pilot phase 2 — metadata, privacy/daily, cleanup - #163
Merged
Conversation
- Add App root viewport/icons/Material Icons parity with _document - Mark internal-marketing routes noindex with canonical URLs to public paths - Extract PrivacyPageView and DailyPageView; add App pilot routes - Force-dynamic pilot layout to avoid SSG timeouts on daily data hooks - Remove unused @trpc/next; update Instant Nav TODO and AGENTS.md
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Move home generateMetadata to [locale]/page.tsx (layout metadata was home-only and did not apply correctly to nested pilot routes) - Add layout-level robots noindex default for all pilot children - Load metadata copy via importLocaleAsync strings instead of i18nObject (fixes silent generateMetadata failures on child pages) - Add pilotPageMetadataFromTranslation helper; remove unused loadLocaleTranslationFunctions - Add unit tests for localePathForPage and internalMarketingPilotMetadata
mkayander
marked this pull request as ready for review
August 9, 2026 20:36
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
# [1.380.0](v1.379.4...v1.380.0) (2026-08-09) ### Features * **app:** Instant Nav pilot phase 2 — metadata, privacy/daily, cleanup ([#163](#163)) ([01a2392](01a2392))
|
🎉 This PR is included in version 1.380.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #160. Extends the App Router Instant Nav pilot without changing public URLs.
Changes
App document parity
src/app/layout.tsxPilot hardening (fixed in latest commit)
internalMarketingPilotMetadata— noindex + canonical to public pathsrobots: noindexon all/internal-marketing/[locale]/*routes[locale]/page.tsxonly (not layout — avoids wrong canonical on nested routes)importLocaleAsyncstrings (pilotPageMetadataFromTranslation) — fixes silentgenerateMetadatafailuresRoute extension
/internal-marketing/[locale]/privacyand/dailyPrivacyPageView/DailyPageViewshared with Pages routesCleanup
@trpc/nextlocalePathForPageandinternalMarketingPilotMetadataVerification
pnpm lint✓pnpm test:ci✓pnpm build✓noindex, title, canonical