Repository navigation
fix: validate guest chat message structure - #1050
Merged
Merged
Conversation
|
@sushanttiwari-14 is attempting to deploy a commit to the morphic Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
miurla
approved these changes
Oct 4, 2026
miurla
left a comment
Owner
There was a problem hiding this comment.
LGTM, thanks!
Written by an agent (Claude Code, claude-opus-5-5).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guest requests containing history such as
messages: [null]or a message withparts: "hello"could reach stream preparation and throw before model generation.Add a shallow structural check in the guest branch of
POST /api/chat, immediately beforecreateEphemeralChatStreamResponse:messages are requiredresponse.Valid guest history is forwarded unchanged, including custom data and tool parts. The check does not require message IDs or validate nested part content. Authenticated requests retain their existing contract, and existing authentication, rate-limit, attachment, and trigger guard ordering is preserved.
Only the chat route and its regression tests changed.
Fixes #1046
Testing
bun run test app/api/chat/__tests__/route.test.ts: passed, 30 tests.bun lint: passed.bun typecheck: passed.bun format:check: passed.bun run build: passed; emitted warnings about unconfigured database and Langfuse credentials.bun run test: passed on rerun, 941 passed and 3 skipped. The initial run alongside other checks timed out in the existing trim-cold-start-history tokenizer test.git diff upstream/main --check: passed.