Skip to content

ci: sync review status workflow with repo-baseline - #384

Merged
minjunkim-dev merged 1 commit into
mainfrom
ci/sync-review-status-workflow-5c3e
Nov 6, 2026
Merged

minjunkim-dev merged 1 commit into
mainfrom
ci/sync-review-status-workflow-5c3e

Conversation

@minjunkim-dev

@minjunkim-dev minjunkim-dev commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Author: Cursor 클라우드 에이전트 / Grok 4.7

Summary

smallnext #383이 repo-baseline 9a3920b 검사기는 다시 복사했지만, .github/workflows/review-status.yml은 템플릿보다 오래된 사본이었다. Opus가 repo-baseline #30에 C-smallnext-B1로 남겼다. 이 PR은 그 파일만 템플릿과 같게 맞춘다.

바뀐 것: 편집 댓글 주석 4줄과 COMMENT_ACTION: ${{ github.event.action }}. blob은 템플릿과 같은 13314a37de6a64951549d3aeab7d2a9f17f501f0이다. created·edited·deleted는 이전과 같이 재실행한다. 알 수 없는 action은 재실행과 실패 체크를 올리지 않고 끝난다. 미설정일 때는 그 가드가 이 저장소에서만 꺼져 있었다. job 이름, 트리거, 권한, checkout ref는 같다.

What lagged: the review-status workflow, not the hashed scripts. What was synced: templates/review-status.yml from repo-baseline main 9a3920b942695257772f25083e8a4fde5d4e3208. Left alone: pr-policy.yml (already identical), hashed scripts from #383, other project workflows, .github/repository-settings.json, APP_ID, branch protection, the review/gate App (repo-baseline #40), commit statuses, and merge.

관련 Issue는 생략한다. ci 유지보수이고 smallnext Issue는 없다. 근거는 위 댓글이다. 플래그: 해당 없음.

Evidence

head: 639ba6963f9b393e5b4f05bd562a0749a8eb2b22
base: a78c4324256c3f831dc26bc859aea7781ada033d

로컬:

  • python3 scripts/check_repository.py — PASS (308 files)
  • python3 scripts/workflow_policy.py — PASS
  • python3 scripts/check_repo_baseline.py — PASS
  • git diff --check — 통과
  • python3 -m unittest discover -s scripts -p 'test_*.py' — 494 tests, OK, skipped 6
  • actionlint 1.7.12 — 통과

CI (head 639ba6963f9b393e5b4f05bd562a0749a8eb2b22):

검사 결과
PR conventions SUCCESS. run 42178938754
Repository hygiene SUCCESS. run 42178731754
Project checks SUCCESS. run 42178731864. api / verify, ios / test, android / build, android / device-tests, container / image, scope 모두 SUCCESS
CodeQL SUCCESS. actions, python, java-kotlin, rust. run 42178731781
CodeRabbit SUCCESS. 줄 단위 스레드는 0개다. Autofix는 쓰지 않았다
Review status FAIL. run 42178939073. review/independent, review/security, review/owner-approval, review/evidence가 없다. 로그는 review evidence: model, model이다. 버그 찾기와 Security가 미실행이라 그렇다. status와 승인 댓글은 남기지 않았다

이 본문을 고치면 같은 head에서 PR conventions와 Review status가 다시 돈다. Review status는 status와 승인 댓글을 남기지 않으므로 다시 실패한다.

확인하지 않은 범위: commit status, 승인 댓글, 병합, branch protection 적용, 기기, 배포. 이 PR은 그것들을 하지 않는다.

Merge Danger

Door: 되돌리기 어려움

영향 범위: .github/workflows/review-status.yml은 POLICY §5 공통 경로이고 §10 게이트 경로다. COMMENT_ACTION을 넘기면 알 수 없는 댓글 action은 재실행하지 않는다. 세 가지 action의 재실행은 같다. 필수 체크 이름과 .github/repository-settings.json은 바꾸지 않는다. 서버 보호도 바꾸지 않는다.

복구: 이 커밋을 revert하는 PR로 올리면 된다. 이미 남은 commit status와 댓글은 revert만으로 지워지지 않는다.

신뢰 경계 기준: .github/workflows/**

되돌리기 어려움이다. 승인 댓글과 병합은 하지 않는다. commit status도 남기지 않는다. 버그 찾기와 Security는 이 저장소에서 실행하지 않았다. 리드가 Mac Claude 리뷰를 따로 잡는다.

Review evidence

작성 패밀리는 Grok이다. Standards와 Spec은 Composer 2.5가 이 head를 봤다. effort 칸은 설정 없음이다. 버그 찾기와 Security는 Mac Claude Opus 한 패스(합침)로 봤다. 버그 P2 1건은 baseline 후속이다.

axis model effort head SHA P0 P1 P2 result
Standards Composer 2.5 설정 없음 639ba69 0 0 0 통과
Spec Composer 2.5 설정 없음 639ba69 0 0 0 통과. Door는 되돌리기 어려움
버그 찾기 Claude Opus 기본 639ba69 0 0 1 통과. P2는 baseline rerun_review_status 후속
Security Claude Opus 기본 639ba69 0 0 0 통과
Open in Web Open in Cursor 

Summary by CodeRabbit

  • Chores
    • Updated review-status workflow notes to clarify how edited owner comments are handled and when they are skipped.
    • Improved event context available to the workflow when processing comments. These maintenance changes affect review automation only; no changes to application features or the end-user experience are included.

repo-baseline 9a3920b의 templates/review-status.yml을 복사한다.
댓글 재실행에 COMMENT_ACTION을 넘기고, 편집 댓글 주석을 맞춘다.

Co-authored-by: MINJUN KIM <minjunkim.dev@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The workflow now documents how edited owner comments affect review-status checks. The comment job also receives the GitHub event action through COMMENT_ACTION.

Changes: Comment action handling

Layer / File(s) Summary
Document and pass comment action
.github/workflows/review-status.yml
The workflow comments describe the checker’s updated_at and created_at requirement and the effect of skipping edited events. The comment job receives github.event.action as COMMENT_ACTION.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • minjunkim-dev/smallnext#378: Moves owner-comment reruns into scripts/rerun_review_status.py; this PR passes the comment action to that script.
  • minjunkim-dev/smallnext#383: Adds comment-action filtering and rejects edited approval comments; this PR passes the comment action and documents the checker behavior.
  • minjunkim-dev/smallnext#375: Introduces the review-status workflow and owner-comment reruns, which this PR continues to update.
Merge Risk: Minimal · up to 639ba

No actionable change-related risk remains. Required review statuses are still pending.

Security architecture risk: Minimal · up to 639ba

The workflow now supplies an action value that its existing dispatcher already supports. All configured comment events retain their previous behavior, with no expanded permissions or access to pull-request code. No material security risk was identified as introduced or worsened by this change.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • observed — The existing privileged effects are repository-local workflow reruns and check-run writes. The comment job retains actions:write and checks:write, while the dispatcher targets this repository’s review-status workflow and a fetched PR head. This PR adds no permission or credential source.

Trust Boundaries and Controls

  • observed — The privileged comment job requires an open pull request and a comment authored by the repository owner. It checks out the default branch with persisted credentials disabled, rather than checking out the PR head. Event action metadata enters through an environment variable and is compared against a fixed allowlist; it is not interpolated into executable shell text.

Resilience and Maintainability Implications

  • inferred — The action binding preserves the existing approval-revocation path because created, edited, and deleted are accepted by both the workflow trigger and dispatcher. Existing cancellation and recovery limitations are not expanded by this PR; source comparison supports compatibility, not a universal runtime guarantee.
Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description includes the required sections, but the review evidence conflicts. It says bug-finding and Security reviews were not run, while the table says both passed. It also reports a failed Rev… Clarify whether the bug-finding and Security reviews ran. Update the review table and CI evidence to show their actual status and results for the stated head SHA.
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title clearly describes the review-status workflow sync.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required sections, but the review evidence conflicts. It says bug-finding and Security reviews were not run, while the table says both passed. It also reports a failed Review status check.

Resolution

Clarify whether the bug-finding and Security reviews ran. Update the review table and CI evidence to show their actual status and results for the stated head SHA.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 63fbb776-3346-4c15-be55-8e6caf02bc2e
Commits

Reviewing files that changed from the base of the PR and between a78c432 and 639ba69.

Files selected for processing: 1

  • .github/workflows/review-status.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@minjunkim-dev

Copy link
Copy Markdown
Owner Author

되돌리기 어려움 승인: 639ba69

@minjunkim-dev
minjunkim-dev merged commit 6a8c865 into main Nov 6, 2026
29 of 33 checks passed
@minjunkim-dev
minjunkim-dev deleted the ci/sync-review-status-workflow-5c3e branch November 6, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants