Skip to content

feat(policy): add Delta Sharing actions for reading other owners' shares and recipients - #286

Merged
harshavardhana merged 1 commit into
minio:mainfrom
harshavardhana:deltasharing-use-actions
Oct 16, 2026
Merged

harshavardhana merged 1 commit into
minio:mainfrom
harshavardhana:deltasharing-use-actions

Conversation

@harshavardhana

@harshavardhana harshavardhana commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Description

Adds admin:DeltaSharingUseShare and admin:DeltaSharingUseRecipient. They let a
Delta Sharing provider read shares and recipients that other users own, matching
the USE_SHARE and USE_RECIPIENT privileges of the OpenSharing reference server.
Writes stay with the owner. admin:* and admin:DeltaSharing* cover both.

Motivation

Needed by miniohq/aistor#8060 (OpenSharing provider API).

Tests

TestDeltaSharingUseActions checks that both actions are valid and matched by
admin:* and admin:DeltaSharing*. Removing either action from
SupportedAdminActions fails it.

Summary by CodeRabbit

  • New Features
    • Added support for Delta Sharing actions for using shares and recipients in admin policies. These actions are recognized as valid admin actions and can be covered by broad admin rules or Delta Sharing-specific policy rules, allowing administrators to manage access to these operations through existing policy controls.

…res and recipients

admin:DeltaSharingUseShare and admin:DeltaSharingUseRecipient let a provider read
shares and recipients that other users own, matching the USE_SHARE and USE_RECIPIENT
privileges of the OpenSharing reference server. Writes stay with the owner.
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c2c2b620-e1c1-4b80-9f22-7998a28f5c27
📥 Commits

Reviewing files that changed from the base of the PR and between 6679633 and b826186.

📒 Files selected for processing: 2
  • policy/admin-action.go
  • policy/admin-action_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The admin action set now includes Delta Sharing actions for using other users’ shares and recipients. Tests check that both actions are valid, match admin:*, and are allowed by a policy matching admin:DeltaSharing*.

Changes: Delta Sharing Admin Actions

Layer / File(s) Summary
Add and validate Delta Sharing actions
policy/admin-action.go, policy/admin-action_test.go
Adds and registers DeltaSharingUseShareAction and DeltaSharingUseRecipientAction. Tests check validity and policy matching.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Suggested reviewers: klauspost

Merge Risk: ⚪ Minimal · up to b8261

This change makes the two Delta Sharing read-action names available to the policy system and its admin wildcard. No concrete merge-blocking behavior or permission issue is established in the inspected change.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the addition of Delta Sharing actions and specifies their read purpose for shares and recipients owned by other users.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the action list,
Two Delta names are on the wrist.
Shares and recipients join the queue,
Tests check their policies too.
Then hops away beneath the moon.

Comment @coderabbitai help to get the list of available commands.

@harshavardhana
harshavardhana merged commit e8116cf into minio:main Oct 16, 2026
11 checks passed
@harshavardhana
harshavardhana deleted the deltasharing-use-actions branch October 16, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant