Repository navigation
chore(ci): disable upstream-only license-check and code-coverage workflows - #63
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
kaovilai
changed the title
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Commit 2893c34 mangled epoch_manager_test.go: it left 'cs' undeclared in TestIndexEpochManager_NoCompactionInReadOnly and dropped TestNoEpochAdvanceOnIndexRead, so internal/epoch failed to build and the Tests / code-coverage workflows failed. Restore the pre-bump test file and disable cleanup writes on index load in TestNoEpochAdvanceOnIndexRead, matching the other epoch tests, since the test env enables them by default. Co-Authored-By: Claude Code (model: Claude Sonnet 5.5) <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
shubham-pampattiwar
left a comment
shubham-pampattiwar
left a comment
There was a problem hiding this comment.
Reviewed the disabled auxiliary workflows and epoch test repair. Tests, compatibility checks, and the Prow build pass. No blocking findings.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Disable
license-check.ymlandcode-coverage.yml, which fail on every PR to this branch. PRs #59, #57, #42, #39, #31 and #12 were merged with them red. Uses the same.disabledrename as #18/#19.tests.ymlis left enabled: it fails withinternal/epoch [build failed], which is a code issue rather than a workflow defect. Title check is covered by #58.Note
Responses generated with Claude (model: Claude Sonnet 5.5)