Repository navigation
fix: normalize line endings before parsing pyproject.toml - #26232
Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25809
When
pyproject.tomluses CRLF line endings (\r\n) on Windows and contains comments (e.g.# comment),@iarna/tomlthrows an error:Control characters (codes < 0x1f and 0x7f) are not allowed in comments, use \u000d insteadbecause it encounters carriage return characters (
\r) within comments. This causestomlParseto fail withFailed to parse pyproject.tomlerror logs and prevent detection of pip-installable projects and optional dependencies.Changes
src/client/pythonEnvironments/creation/provider/venvUtils.ts, normalize\r\nand\rline endings to\nintomlParsebefore delegating totomljs.parse.src/test/pythonEnvironments/creation/provider/venvUtils.unit.test.tsverifying thatisPipInstallableTomlandpickPackagesToInstallparsepyproject.tomlwith CRLF line endings and comments without errors.Verification
npx tsc -p ./succeeded with 0 errors.npx mocha --require out/test/unittests.js out/test/pythonEnvironments/creation/provider/venvUtils.unit.test.js --ui tdd(20 passed).