Skip to content

Pin GitHub Actions to full-length commit SHAs #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dan Fiedler (danfiedler-msft) wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −6
Open

Pin GitHub Actions to full-length commit SHAs #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6d4af5
Pin GitHub Actions to full-length commit SHAs
danfiedler-msft Oct 8, 2026
27f5729
Merge branch 'main' into danfiedler/pin-actions
edvilme Oct 8, 2026
6bff9ff
Merge branch 'main' into danfiedler/pin-actions
eleanorjboyd Oct 12, 2026
7a90aae
Merge branch 'main' into danfiedler/pin-actions
edvilme Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
sparse-checkout-cone-mode: false

- name: Install Rust Toolchain
uses: dtolnay/rust-toolchain@stable
uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 # v1

@heejaechang Heejae Chang (heejaechang) Oct 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue · Please address or respond

Unlike @stable, this pinned revision requires an explicit toolchain input; omitting it causes Rust setup to exit with code 1 before building Python Environment Tools. Add with: { toolchain: stable } to all three changed steps here and all three in .github/workflows/push-check.yml.

@heejaechang Heejae Chang (heejaechang) Oct 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue · Please address or respond

📍 .github/workflows/pr-check.yml:103
High — unresolved prior feedback (inline_comment:4266564410). Unlike @stable, this pinned revision requires an explicit toolchain input and exits with code 1 when it is missing, blocking the normal Rust setup/build path. Add with: { toolchain: stable } at all six invocations: this file's lines 103, 192, and 284, and .github/workflows/push-check.yml lines 104, 193, and 285, while retaining the SHA pins.

[verified]


- name: Cache Rust build
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
sparse-checkout-cone-mode: false

- name: Install Rust Toolchain
uses: dtolnay/rust-toolchain@stable
uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 # v1

- name: Cache Rust build
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
Expand Down Expand Up @@ -281,7 +281,7 @@ jobs:
sparse-checkout-cone-mode: false

- name: Install Rust Toolchain
uses: dtolnay/rust-toolchain@stable
uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 # v1

- name: Cache Rust build
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/push-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
sparse-checkout-cone-mode: false

- name: Install Rust Toolchain
uses: dtolnay/rust-toolchain@stable
uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 # v1

- name: Cache Rust build
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
Expand Down Expand Up @@ -190,7 +190,7 @@ jobs:
sparse-checkout-cone-mode: false

- name: Install Rust Toolchain
uses: dtolnay/rust-toolchain@stable
uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 # v1

- name: Cache Rust build
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
Expand Down Expand Up @@ -282,7 +282,7 @@ jobs:
sparse-checkout-cone-mode: false

- name: Install Rust Toolchain
uses: dtolnay/rust-toolchain@stable
uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 # v1

- name: Cache Rust build
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
Expand Down
Loading