fix: keep debugjava executable on POSIX - #1663
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debugjavawrapper to remain LF on Windows checkoutspreserving all other ordinary and special Unix permission bits
Windows no-op path
Why
The official VSIX is built on Windows. Version 0.59.0 consequently shipped
debugjavawith CRLF line endings and without usable execute permission onLinux. Changing only the Git mode would not survive that build path, while
changing only the line-ending policy would still leave the installed wrapper
non-executable.
Fixes #1662.
Tests
npm run tslintnpx tsc -p .npx @vscode/vsce@latest package-rwxr-xr-x, zero CR bytes, andbash -ncore.autocrlf=true: the wrapper remained LFThe repository-pinned
@vscode/test-electron2.4.1 resolves the old macOSbinary name
Electron, while the downloaded VS Code 1.131.0 bundle containsContents/MacOS/Code. I ran the same compiled extension suite throughrunTestswith that actual executable path; all 33 tests passed.