Skip to content

Update inactive regions to support column granularity - #14667

Open
Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
mainfrom
dev/coleng/inactive_regions_columns
Open

Update inactive regions to support column granularity#14667
Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
mainfrom
dev/coleng/inactive_regions_columns

Conversation

@Colengms

Copy link
Copy Markdown
Contributor

Added column fields.
Broke out a separate line-only object for code folding, which doesn't currently support column offsets.

@8prashant

Copy link
Copy Markdown

Thanks for the update, Colen Garoutte-Carson (@Colengms) .
That makes sense. Since the complete fix needs the native-side changes as well, I'm fine with abandoning this PR #14666 in favor of #14667 .
If any part of this TypeScript-side change or investigation was useful as a reference, would you mind adding a Co-authored-by trailer if appropriate?
Either way, thank you for taking this forward. I'll abandon this PR #14666 .

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates inactive-region decorations to support column-level precision while preserving line-only folding ranges.

Changes:

  • Adds column fields to inactive regions.
  • Introduces a line-only range type for code folding.
  • Applies precise ranges to inactive-region decorations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pull Request

Development

Successfully merging this pull request may close these issues.

4 participants