Skip to content

Maintenance of pandas type stubs #35

Closed

Description

@Dr-Irv

The pandas team has an open issue with regards to type stubs: pandas-dev/pandas#28142

We'd like to have some discussion with the key developers (Jake Bailey (@jakebailey) ? Graham Wheeler (@gramster) ? others ?) of the pandas type stubs to determine a best way forward for upkeep of these type stubs. I brought this up at our December, 2020, monthly core developers meeting.

Might be best for you guys to contribute over there in that pandas issue.

Thanks!

Activity

  1. gramster commented on Jan 5, 2021

    @gramster
    Contributor

    Hi Irv, we'd be very interested in having this discussion; what forum do you suggest?

  2. Dr-Irv commented on Jan 5, 2021

    @Dr-Irv
    ContributorAuthor

    Hi Irv, we'd be very interested in having this discussion; what forum do you suggest?

    Thanks for commenting on the pandas issue. I will also bring it up with the core team as we may want to do a deeper discussion in our next core dev meeting (which I believe is on 1/13/2021).

  3. Dr-Irv commented on Jan 6, 2021

    @Dr-Irv
    ContributorAuthor

    Graham Wheeler (@gramster) Eric Traut (@erictraut) Info on our monthly dev meeting can be found here: https://pandas.pydata.org/docs/development/meeting.html

    It would be great if you could attend the next one on 1/13/2021 at 1PM Eastern time, as we'd like to have a discussion with you on how to move forward. Thanks!

  4. gvanrossum commented on Jan 6, 2021

    @gvanrossum

    I'd like to attend -- is that okay? I might know a thing or two about stubs (though not necessarily about the ins and outs of how Pylance and Pyright use them -- the expert there would be Eric Traut (@erictraut)).

  5. Dr-Irv commented on Jan 6, 2021

    @Dr-Irv
    ContributorAuthor

    Guido van Rossum (@gvanrossum) absolutely! Our pandas dev meetings are open to all. When I get more info, I will post here.

  6. Dr-Irv commented on Jan 12, 2021

    @Dr-Irv
    ContributorAuthor
  7. gramster commented on Feb 4, 2022

    @gramster
    Contributor

    I think we have a rough plan of action:

    • add tests to the stubs to improve the quality and avoid regressions. The adding of initial tests has been done (b19436a) although there is work to be done to pass them and we'll likely want more;
    • following that, we can start upstreaming some of the type annotations from here into pandas; my hope is that we can do that on a file-by-file basis, and as we complete each file, we can remove it from here and start regenerating the stub from the pandas source. I still need to add the tooling to do the latter but will do that once we get to the initial set of upstream commits.
  8. gramster commented on Feb 4, 2022

    @gramster
    Contributor

    Moving this to discussions.

  9. locked and limited conversation to collaborators on Feb 4, 2022
  10. converted this issue into a discussion #147 on Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions