chore(driver): roll to 1.62.0 - #3160
Closed
dcrousso wants to merge 1 commit into
Closed
Conversation
Skn0tt
reviewed
Jul 30, 2026
Skn0tt
left a comment
Skn0tt
left a comment
Member
There was a problem hiding this comment.
I believe this is missing the screencast ack, see microsoft/playwright@bc97a13.
roll the driver to `1.62.0` and regenerate the sync and async APIs from the `v1.62.0` documentation upstream removed the `routeFromHar` `interceptAPIRequests` option before `1.62.0`, so drop `intercept_api_requests`, `HarRouter.add_api_request_route`, and their tests Firefox `153` fixes <microsoft/playwright#38919>, so use the context locale expectation for every browser acknowledge each screencast frame after its callback finishes so the driver can apply backpressure and deliver the next frame
Skn0tt
reviewed
Jul 31, 2026
| ) | ||
| finally: | ||
| if result is not None and hasattr(result, "__await__"): | ||
| self._page._loop.create_task( |
Member
There was a problem hiding this comment.
this task should be somehow returned into the page._channel.on() caller in L54, otherwise exceptions in onFrame customer code are silently swallowed. This isn't a problem in Node.js land because there's the unhandled rejection concept, this doesn't exist in Python though.
Otherwise this is the same as I came up with in #3161, which is a good sign. Let's figure out why these Chromium tests are hanging.
Member
|
The failing CI seems to be related to microsoft/playwright#41303 and Edit: See #3161 (comment). |
Author
|
closing in favor of #3161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls the driver to
1.62.0and regenerates the sync and async APIs from thev1.62.0documentation.Upstream removed the
routeFromHarinterceptAPIRequestsoption before1.62.0in microsoft/playwright#41964 and microsoft/playwright#41965. This dropsintercept_api_requests, theHarRouter.add_api_request_routehelper, therouteAPIRequestsFromHarandunrouteAPIRequestsFromHarcalls, and their tests. The tests asserting API requests are not served from HAR by default remain.Firefox
153fixes microsoft/playwright#38919, so the worker locale test now uses the context locale expectation for every browser.The
1.62.0driver requires eachscreencastFrameevent to be acknowledged after its callback finishes. The Python client now sendsscreencastFrameAckafter sync callbacks and awaited async callbacks, preserving backpressure.Validation:
pre-commitpasses for the modified screencast files12teststests/asyncon Chromium passes with1581tests and7skipped tests68testsPW_SRC_DIRpinned tov1.62.0ate3950d9c140d007bd52853b45813c6274b24e36f