fix(optimizer): prevent Shape/Gather from folding to constants when shape has negative (unknown) dims

[Copilot]

FoldConstantsPass incorrectly folds Shape→Gather→Concat→Reshape patterns when the input tensor has unknown dimensions stored as integer -1 in the IR (as opposed to ir.SymbolicDim). Since -1 is an int, the all-integer check passes, causing Shape to fold into Constant(value_ints=[-1, 512, 1, ...]). Gather then returns a constant -1, which propagates into the Reshape shape — producing an invalid shape like [-1, -1] (ONNX allows at most one -1 in a Reshape shape).

Changes

• Shape handler: add non-negativity guard — only fold to a constant when all shape dims are known positive integers:

  # before
  if all(isinstance(d, int) for d in shape_slice):
  # after
  if all(isinstance(d, int) and d >= 0 for d in shape_slice):

• Gather handler: same guard on the symbolic-shape gather path, preventing folding when any gathered dimension value is negative.
• Regression test: test_shape_gather_concat_reshape_with_neg1_dim — verifies that Shape is preserved and Reshape never receives multiple -1 values when the input shape contains -1 integer dims.

The root cause: ONNX IR deserializes unknown dims (dim_value=-1 in the proto) as integer -1, not ir.SymbolicDim. The existing SymbolicDim path was safe; the -1-as-int path was not.

[Copilot]

Pull request overview

This PR hardens the optimizer’s FoldConstantsPass against ONNX-IR shapes that encode unknown dimensions as the integer -1, preventing invalid constant-folding that can propagate multiple -1 values into Reshape shapes.

Changes:

• Add a non-negativity guard to Shape constant folding so -1 (unknown) dims do not become literal constants.
• Add the same non-negativity guard to the Gather-from-symbolic-shape folding path to avoid folding negative gathered dims.
• Add a regression test covering the Shape→Gather→Concat→Reshape pattern when the input shape contains integer -1 dims.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
onnxscript/optimizer/_constant_folding.py	Prevents folding Shape/Gather results to constants when any folded dimension is negative (unknown).
onnxscript/optimizer/_constant_folding_test.py	Adds regression coverage for the -1-dim folding bug scenario involving Shape/Gather/Reshape.

[Copilot]

Added the non-negativity guard to Size folding so it only folds when all dims are known non-negative ints (commit ba4d21e).

[codecov]

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.63%. Comparing base (d3489d4) to head (20a6d4f).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
onnxscript/optimizer/_constant_folding_test.py	71.42%	3 Missing and 1 partial ⚠️
onnxscript/optimizer/_constant_folding.py	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2964      +/-   ##
==========================================
+ Coverage   72.61%   72.63%   +0.01%     
==========================================
  Files         263      265       +2     
  Lines       32034    32219     +185     
  Branches     3013     3042      +29     
==========================================
+ Hits        23263    23402     +139     
- Misses       7748     7782      +34     
- Partials     1023     1035      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.