migration: allow resume finalize on cancelled destination - #2852
Open
Harsh Rawat (rawahars) wants to merge 1 commit into
Open
migration: allow resume finalize on cancelled destination#2852Harsh Rawat (rawahars) wants to merge 1 commit into
Harsh Rawat (rawahars) wants to merge 1 commit into
Conversation
Harsh Rawat (rawahars)
force-pushed
the
harshrawat/lm-allow-cancel-finalize
branch
from
August 4, 2026 09:38
9916b02 to
6b178a9
Compare
On the destination, a cancelled session previously treated Finalize as a no-op for every action, so the sandbox could never be brought back up on this host after a cancel. However, there are cases where say the VM transfer phase succeeded with a raced cancel and the caller wanted to bring the VM into resume on destination. For such cases, let a resume finalize fall through instead: it finalizes and resumes the VM and its pods, ending in the finalized state (cleanup then returns to idle), matching the source's post-cancel resume. A non-resume finalize on a cancelled destination stays a no-op. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Harsh Rawat (rawahars)
force-pushed
the
harshrawat/lm-allow-cancel-finalize
branch
from
August 5, 2026 09:06
6b178a9 to
7417669
Compare
apurv15
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the destination, a cancelled session previously treated Finalize as a no-op for every action, so the sandbox could never be brought back up on this host after a cancel. However, there are cases where say the VM transfer phase succeeded with a raced cancel and the caller wanted to bring the VM into resume on destination.
For such cases, let a resume finalize fall through instead: it finalizes and resumes the VM and its pods, ending in the finalized state (cleanup then returns to idle), matching the source's post-cancel resume. A non-resume finalize on a cancelled destination stays a no-op.