cmd/containerd-shim-runhcs-v1: fix UserTime_100Ns incorrectly reporting kernel time - #2832
Open
Harshal Patel (HarshalPatel1972) wants to merge 1 commit into
Open
Conversation
…ng kernel time When querying process metrics via containerd's task Pids API, the UserTime_100Ns metric was incorrectly being assigned the value of KernelTime100ns. This updates the assignment to use the correct UserTime100ns field from the underlying HCS ProcessListItem struct. This change includes a unit test verifying the correct mapping of properties from the schema1 ProcessListItem to the runhcsopts.ProcessDetails structure. Signed-off-by: Harshal Patel <hp842484@gmail.com>
Harshal Patel (HarshalPatel1972)
force-pushed
the
fix-usertime-metrics
branch
from
July 20, 2026 13:45
ecf6165 to
e9e4491
Compare
Contributor
|
Harsh Rawat (@rawahars) - PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hcsTask.Pids() incorrectly assigned UserTime_100Ns the value of KernelTime100ns.
This updates the assignment to use the correct UserTime100ns field from the underlying schema1.ProcessListItem struct and adds a unit test to verify the mapping.