Skip to content

fix(mcps): migrate servers to MCP SDK 2 - #18463

Open
Christopher Co (christopherco) wants to merge 1 commit into
microsoft:4.0from
christopherco:chrco/mcp-2-update
Open

fix(mcps): migrate servers to MCP SDK 2#18463
Christopher Co (christopherco) wants to merge 1 commit into
microsoft:4.0from
christopherco:chrco/mcp-2-update

Conversation

@christopherco

@christopherco Christopher Co (christopherco) commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

MCP 2 removes FastMCP and dispatches synchronous tool handlers through
worker threads. The servers relied on serialized execution for mutable
state and the dist-git cache lifecycle.

Update the dependency to 2.0.0, use MCPServer, and serialize tool calls
with a shared lock per server to preserve MCP 1 ordering. Add a regression
test that sends concurrent MCP requests for the same uncached package and
verifies it is cloned only once.

Supersedes: #18415

Copilot AI balanced review requested due to automatic review settings August 15, 2026 04:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates helper MCP servers to MCP Python SDK 2 while preserving decorators and stdio execution.

Changes:

  • Bumps mcp to 2.0.0.
  • Replaces FastMCP with MCPServer.
  • Updates the shared SDK re-export.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/mcps/requirements.txt Pins MCP SDK 2.0.0.
scripts/mcps/_mcp_utils.py Re-exports MCPServer.
scripts/mcps/koji-mcp.py Migrates the Koji server.
scripts/mcps/fedora-distgit-mcp.py Migrates the Fedora dist-git server.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/mcps/requirements.txt

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

@christopherco Christopher Co (christopherco) changed the title fix(mcps): migrate servers to MCP SDK 2 fix(mcps): serialize tools after MCP 2 migration Aug 15, 2026
@christopherco
Christopher Co (christopherco) marked this pull request as ready for review August 15, 2026 07:28
@christopherco Christopher Co (christopherco) changed the title fix(mcps): serialize tools after MCP 2 migration fix(mcps): migrate servers to MCP 2 Aug 15, 2026
@christopherco Christopher Co (christopherco) changed the title fix(mcps): migrate servers to MCP 2 fix(mcps): migrate servers to MCP SDK 2 Aug 15, 2026
@christopherco
Christopher Co (christopherco) force-pushed the chrco/mcp-2-update branch 2 times, most recently from 6458fb5 to 6971212 Compare August 15, 2026 07:34
MCP 2 removes FastMCP and runs synchronous tool handlers concurrently in
worker threads. The servers rely on serialized state and cache access.

Update to MCPServer and use one shared lock context around each server's
tool bodies to preserve MCP 1 ordering. Test concurrent requests for one
uncached package and verify that it is cloned only once.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: dd338a3f-cff6-4b03-8c00-fce99b2ac4a4

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

@christopherco

Copy link
Copy Markdown
Collaborator Author

Switched from the previous decorator to context manager for the shared lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants