Skip to content

Better typings for Array.concat(), etc. - #33645

Closed
Jack Bates (jablko) wants to merge 3 commits into
microsoft:mainfrom
jablko:patch-13
Closed

Better typings for Array.concat(), etc.#33645
Jack Bates (jablko) wants to merge 3 commits into
microsoft:mainfrom
jablko:patch-13

Conversation

@jablko

@jablko Jack Bates (jablko) commented Sep 27, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Roll up #33606, #33620 and #33630

Fixes #19535
Fixes #24579
Fixes #26378
Fixes #26976
Fixes #29604
Fixes #31033

@jablko Jack Bates (jablko) mentioned this pull request Sep 27, 2019
Closed
@jablko
Jack Bates (jablko) force-pushed the patch-13 branch 5 times, most recently from 7cf1280 to b23d8ad Compare September 30, 2019 01:29
@jablko Jack Bates (jablko) changed the title Better typings for Array.concat() and .flatMap() Better typings for Array.concat(), etc. Sep 30, 2019
@jablko
Jack Bates (jablko) force-pushed the patch-13 branch 9 times, most recently from 684dc5d to ee4c5e6 Compare October 7, 2019 14:31
@jablko
Jack Bates (jablko) force-pushed the patch-13 branch 2 times, most recently from 98115c4 to a448f91 Compare October 16, 2019 14:46
@jablko
Jack Bates (jablko) force-pushed the patch-13 branch 2 times, most recently from 0e26a78 to 6b277e3 Compare October 19, 2019 18:33
@jablko
Jack Bates (jablko) force-pushed the patch-13 branch 3 times, most recently from 97d14d8 to 0faa4ed Compare November 17, 2019 14:28
@jablko

Jack Bates (jablko) commented Nov 17, 2019

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) user test this

@orta

Orta Therox (orta) commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) user test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Orta Therox (@orta), I've started to run the extended test suite on this PR at 032ede6. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Orta Therox (@orta), I've started to run the parallelized Definitely Typed test suite on this PR at 032ede6. You can monitor the build here. It should now contribute to this PR's status checks.

@jablko
Jack Bates (jablko) force-pushed the patch-13 branch 3 times, most recently from 2c3101c to 0056e90 Compare January 29, 2020 01:06
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Jan 31, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at 0056e90. You can monitor the build here. It should now contribute to this PR's status checks.

This was referenced Jan 31, 2020
Closed
Closed
Open
@sandersn Nathan Shively-Sanders (sandersn) added the For Backlog Bug PRs that fix a backlog bug label Feb 1, 2020
@jablko

Jack Bates (jablko) commented Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

Ryan Cavanaugh (@RyanCavanaugh) Thanks! Could I please trouble you to trigger TypeScript Bot (@typescript-bot) run dt as well?

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Feb 3, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) run dt

@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the parallelized Definitely Typed test suite on this PR at 77844cc. You can monitor the build here. It should now contribute to this PR's status checks.

@jablko
Jack Bates (jablko) force-pushed the patch-13 branch 2 times, most recently from 43679d2 to 1c95e0e Compare February 4, 2020 18:52
@jablko
Jack Bates (jablko) force-pushed the patch-13 branch 2 times, most recently from 8efba07 to 1e82814 Compare February 13, 2020 15:42
@sandersn

Nathan Shively-Sanders (sandersn) commented Mar 9, 2020

Copy link
Copy Markdown
Member

Daniel Rosenwasser (@DanielRosenwasser) we should probably discuss this in a design meeting after we get an analysis of how breaky it is to user/DT/RWC tests. Though maybe we should hold this until after the existing effort to gather broken Array examples is done.

@ljharb

Jordan Harband (ljharb) commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

Any update on this? I'm hoping it allows for idiomatic usage of eg [].concat(a || [], b || []).

@sandersn

Nathan Shively-Sanders (sandersn) commented Mar 3, 2022

Copy link
Copy Markdown
Member

This has been sitting for a long time, and a big part of that is the difficulty in making any change to array types. I think it has to be a single major update like #36554 nowadays. I'm going to close this PR, although it may be useful as a basis for a part of that work.

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

The TypeScript team hasn't accepted the linked issue #19535. If you can get it accepted, this PR will have a better chance of being reviewed.

@tychenjiajun Jiajun Chen (tychenjiajun) mentioned this pull request Mar 22, 2022
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.