Slai-Agent-Runtime-Fix-Windows-runtime-command-capture-and-patch-paths - #44
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provenance
This Windows runtime issue was identified while reproducing SWE-bench-Live Windows execution failures through Slai Agent Runtime.
Summary
The Windows runtime used a persistent attached PowerShell/ConPTY session for commands. That path could leave commands in an idle prompt and produce incomplete or zero-byte captures. It also inherited Linux patch-path assumptions, which are invalid for native Windows containers.
Changes
exec_runAPI with an explicit PowerShell script and structured exit metadata.C:\\mnt_tmppath and write patch files with LF endings.fakerepoendpoint.Validation
python -m py_compile launch/core/platforms/linux.py launch/core/platforms/windows.py tests/runtime_test.pygit diff --checkpython -m pytest -q tests/runtime_test.py -k runtime_constructor_attributes— 3 passed, 3 deselectedThe full Docker integration matrix was not claimed because it requires a Windows Docker engine and matching Windows container image on the current host.
This PR is intentionally focused on runtime execution/capture and patch transport; it does not modify SWE-bench evaluator metadata or candidate patches.