Skip to content

knowledge: improve review precision from BCApps PR 10990-neg-8222ad38e67a1bf4ee3b67d2389a957f0d00c77a feedback #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Wenjie Fan (gggdttt) wants to merge 1 commit into from
Closed

knowledge: improve review precision from BCApps PR 10990-neg-8222ad38e67a1bf4ee3b67d2389a957f0d00c77a feedback #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions microsoft/knowledge/upgrade/demo-data-seeding-needs-no-upgrade-path.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
bc-version: [all]
domain: upgrade
keywords: [demo-data, contoso, preview, setup, false-positive, upgrade-codeunit]
technologies: [al]
countries: [w1]
application-area: [all]
---

# Contoso/demo-data seeding needs no upgrade codeunit

## Description

Demo-data generators (for example Contoso module codeunits invoked from a
setup/demo-data-creation entry point) are not part of the tenant-upgrade
pipeline. They populate sample records for a demo, preview, or trial company
on explicit, manual invocation of the demo-data tool — they do not run
automatically for already-provisioned tenants the way `OnUpgradePerCompany`
or `OnUpgradePerDatabase` do, and they are not expected to. Wiring a new demo
record set only into the existing `CreateMasterData`-style entry point is
correct; it is not a missing upgrade path, because there is no real tenant
data to backfill.

## Best Practice

Keep demo/Contoso seeding codeunits (`Codeunit.Run` chains invoked from demo
data creation, e.g. `CreateMasterData`) wired only into the demo-data
generation flow. Do not require an `Subtype = Upgrade` codeunit or
`OnUpgradePerCompany`/`OnUpgradePerDatabase` trigger for this kind of seeding;
the data is regenerated on demand, not migrated for existing tenants.

## Anti Pattern

Flagging a new demo/Contoso data-seeding step (e.g. a VAT-rate seeding
codeunit run from `CreateMasterData`) as missing an upgrade entry point on
the theory that previously provisioned tenants will not receive it on
upgrade. Demo-data modules are not upgraded; they are re-run by the demo
tool.
Loading