Skip to content

[28.x][Subscription Billing] Sales-Explode BOM fails for foreign-currency customer #11825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fixes4BC (neeleshsinghal) wants to merge 2 commits into from
+47 −1
Closed

[28.x][Subscription Billing] Sales-Explode BOM fails for foreign-currency customer #11825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5b532d
Fix and Automation
neeleshsinghal Sep 23, 2026
595432e
Merge branch 'releases/28.x' of https://github.com/microsoft/BCApps i…
neeleshsinghal Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../Subscription Billing/App/Sales Service Commitments/Tables/SalesSubscriptionLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ table 8068 "Sales Subscription Line"

local procedure GetDate(): Date
begin
SalesLine.Get(Rec."Document Type", Rec."Document No.", Rec."Document Line No.");
GetSalesLine(SalesLine);
exit(SalesLine.GetDate());
end;

Expand Down
46 changes: 46 additions & 0 deletions ...s/W1/Subscription Billing/Test/Service Commitments/SalesServiceCommitmentTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1947,6 +1947,52 @@ codeunit 139915 "Sales Service Commitment Test"
ServiceCommitment.TestField("Subscription Line End Date", 0D);
end;

[Test]
[HandlerFunctions('StrMenuHandler')]
procedure TestTransferSalesServiceCommitmentsOnExplodeBOMForFCYCustomer()
var
Item2: Record Item;
Currency2: Record Currency;
begin
// [SCENARIO 649784] Exploding an Assembly BOM on a sales order for a foreign-currency
// customer creates the Sales Subscription Line without a "Sales Line does not exist" error.

// [GIVEN] An Assembly item with a sales service commitment BOM component
Initialize();

LibraryAssembly.CreateItem(Item2, Item."Costing Method"::Standard, Item."Replenishment System"::Assembly, '', '');
CreateComponentItemWithSalesServiceCommitments(Item2."No.");

// [GIVEN] A foreign currency with an exchange rate
LibraryERM.CreateCurrency(Currency2);
LibraryERM.CreateRandomExchangeRate(Currency2.Code);

// [GIVEN] A customer using the foreign currency
LibrarySales.CreateCustomer(Customer);
Customer.Validate("Currency Code", Currency2.Code);
Customer.Modify(true);

// [GIVEN] A sales order for the foreign-currency customer
LibrarySales.CreateSalesHeader(SalesHeader, SalesHeader."Document Type"::Order, Customer."No.");

// [GIVEN] The Assembly item is added to the sales order
LibrarySales.CreateSalesLineWithShipmentDate(SalesLine, SalesHeader, Enum::"Sales Line Type"::Item, Item2."No.", WorkDate(), LibraryRandom.RandInt(100));

// [WHEN] The BOM is exploded
Codeunit.Run(Codeunit::"Sales-Explode BOM", SalesLine);

// [THEN] The BOM component Sales Line is created
SalesLine.SetRange("Document Type", SalesHeader."Document Type");
SalesLine.SetRange("Document No.", SalesHeader."No.");
SalesLine.SetRange(Type, Enum::"Sales Line Type"::Item);
SalesLine.SetRange("No.", Item."No.");
SalesLine.FindLast();

// [THEN] A Sales Subscription Line is created for the BOM component
SalesLine.CalcFields("Subscription Lines");
SalesLine.TestField("Subscription Lines");
end;

#endregion Tests

#region Procedures
Expand Down
Loading