Skip to content

[28.x][Subscription Billing] Sales-Explode BOM fails for foreign-currency customer - #11825

Closed
Fixes4BC (neeleshsinghal) wants to merge 2 commits into
releases/28.xfrom
bugs/Bug-649784-Sales-Explode-BOM-fails-for-foreign-currency-customers
Closed

Fixes4BC (neeleshsinghal) wants to merge 2 commits into
releases/28.xfrom
bugs/Bug-649784-Sales-Explode-BOM-fails-for-foreign-currency-customers

Conversation

@neeleshsinghal

@neeleshsinghal Fixes4BC (neeleshsinghal) commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@neeleshsinghal
Fixes4BC (neeleshsinghal) requested a review from a team as a code owner September 23, 2026 20:32
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Sep 23, 2026
…nto bugs/Bug-649784-Sales-Explode-BOM-fails-for-foreign-currency-customers
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This changes Sales Subscription Line.GetDate() to reuse the in-memory sales line before falling back to a database lookup. That matches the BOM explosion flow, where subscription line validation can run before the component sales line is safely available through the old direct lookup. The added test covers a foreign-currency customer, explodes an assembly BOM, and verifies that the component subscription line is created.

Problem-solution fit

Fit: Strong

The reported failure is a specific foreign-currency BOM explosion path, and the changed lookup is exactly on the call path that raised the missing sales line error. The test recreates that path and checks the expected subscription line result.

Suggestions

None.

Risk assessment and necessity

Risk: The change is narrow. It routes GetDate() through the existing GetSalesLine helper, keeps the old database fallback, and uses the cached line only when it matches the current subscription line. The publisher side raises the subscriber event after inserting the BOM component sales line, so the cached line is available at the needed point.

Necessity: The change is needed to let foreign-currency sales orders explode an assembly BOM and create the related subscription lines. The scope is right for the bug and includes a direct regression test.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11825 round=1 by=alexei-dobriansky at=2026-09-24T01:05:06Z lastSha=595432e7e3186f08e9f0d3bb1d35d2a85a09cb6d reviewKey=ff392ae06cf0923e9abfbd74f189b58a9c73834b395082440978cb6b8bdb5a8d suggestions=

@github-actions

Copy link
Copy Markdown
Contributor

Could not find a linked work item. Please link one in either of these ways: (1) link an ADO work item using the pattern 'AB#' followed by the work item number - you may use the 'Fixes' keyword to automatically resolve it when the pull request is merged, e.g. 'Fixes AB#1234'; or (2) link a GitHub issue of type 'Task' using the pattern 'Fixes #' followed by the issue number, e.g. 'Fixes #1234'.

@neeleshsinghal
Fixes4BC (neeleshsinghal) deleted the bugs/Bug-649784-Sales-Explode-BOM-fails-for-foreign-currency-customers branch September 24, 2026 13:17

This branch was successfully deployed

1 active deployment
triage — 595432e7 Deployed Sep 24, 2026 by neeleshsinghal via Classify team ownership #5693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants