[W1][codeunit][102][Import Consolidation from API] OnBeforeGetGLEntries

[BertDeTemmerman]

Why do you need this change?

We want to filter the fetched GL entries of the consolidation on dimension 4.
But we are unable to because the OnBeforeGetGLEntries event doesn't provide the filter string.
The request is also send with a fixed filter.

We could make the request it, but then would have also need to reauthenticate, but against what Url?

Describe the request

A possible solution would be to have the filter part of the event, so we can update the filter string in a subscriber.

    local procedure GetGLEntries(DateFilter: Text; AccountNoFilter: Text): JsonArray
    var
        Filter, Response: Text;
        IsHandled: Boolean;
    begin
        Filter := '/generalLedgerEntries?$filter=' + DateFilter + ' and (' + AccountNoFilter + ')&$expand=dimensionSetLines', true)');
        OnBeforeGetGLEntries(DateFilter, AccountNoFilter, IsHandled, Response, Filter);
        if IsHandled then
            exit(ParseData(Response));
        exit(HttpGet(BusinessUnitAPIBaseUrl + Filter);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeGetGLEntries(DateFilter: Text; AccountNoFilter: Text; var IsHandled: Boolean; var Response: Text; var Filter: Text)
    begin
    end;

Likewise for OnBeforeGetGLEntriesCountAtDate

    local procedure GetGLEntriesCountAtDate(GLAccountNo: Code[20]; ClosingDate: Date): Integer
    var
        Filter, Response: Text;
        IsHandled: Boolean;
    begin
        Filter :=  '/generalLedgerEntries?$filter=' + GLAccountToFilter(GLAccountNo) + ' and postingDate eq ' + FormatDateForAPICall(ClosingDate));
        OnBeforeGetGLEntriesCountAtDate(GLAccountNo, ClosingDate, IsHandled, Response, Filter);
        if IsHandled then
            exit(ParseCount(Response));
        exit(HttpGetCount(BusinessUnitAPIBaseUrl + Filter);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeGetGLEntriesCountAtDate(GLAccountNo: Code[20]; ClosingDate: Date; var IsHandled: Boolean; var Response: Text; var Filter: Text)
    begin
    end;

Provide an implementation (optional)

• I will provide the implementation for this extensibility request

[github-actions]

✅ Analysis complete - ready for further processing

---

Implementation:

Add a var Filter: Text parameter to OnBeforeGetGLEntries and OnBeforeGetGLEntriesCountAtDate, build the OData filter into a local variable before each event, and use that variable when issuing the HTTP request.

Location in GetGLEntries and GetGLEntriesCountAtDate:

    local procedure GetGLEntries(DateFilter: Text; AccountNoFilter: Text): JsonArray
    var
        Response: Text;
        IsHandled: Boolean;
        Filter: Text;
    begin
        Filter := DateFilter + ' and (' + AccountNoFilter + ')';
        OnBeforeGetGLEntries(DateFilter, AccountNoFilter, IsHandled, Response, Filter);
        if IsHandled then
            exit(ParseData(Response));
        exit(HttpGet(BusinessUnitAPIBaseUrl + '/generalLedgerEntries?$filter=' + Filter + '&$expand=dimensionSetLines', true));
    end;

    local procedure GetGLEntriesCountAtDate(GLAccountNo: Code[20]; ClosingDate: Date): Integer
    var
        Response: Text;
        IsHandled: Boolean;
        Filter: Text;
    begin
        Filter := GLAccountToFilter(GLAccountNo) + ' and postingDate eq ' + FormatDateForAPICall(ClosingDate);
        OnBeforeGetGLEntriesCountAtDate(GLAccountNo, ClosingDate, IsHandled, Response, Filter);
        if IsHandled then
            exit(ParseCount(Response));
        exit(HttpGetCount(BusinessUnitAPIBaseUrl + '/generalLedgerEntries?$filter=' + Filter));
    end;

Event Publisher (add at the end of the codeunit with other events):

    [IntegrationEvent(false, false)]
    local procedure OnBeforeGetGLEntries(DateFilter: Text; AccountNoFilter: Text; var IsHandled: Boolean; var Response: Text; var Filter: Text)
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeGetGLEntriesCountAtDate(GLAccountNo: Code[20]; ClosingDate: Date; var IsHandled: Boolean; var Response: Text; var Filter: Text)
    begin
    end;

---

File: ImportConsolidationFromAPI.Codeunit.al

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Is the triage result incorrect? Reply with /not-accurate and briefly explain what was wrong. Your feedback improves future responses.