Skip to content

Refresh pinned BC artifacts after full verification - #894

Merged
Sun Haoran (haoranpb) merged 7 commits into
mainfrom
artifact/refresh-bc-container-urls
Sep 30, 2026
Merged

Sun Haoran (haoranpb) merged 7 commits into
mainfrom
artifact/refresh-bc-container-urls

Conversation

@haoranpb

@haoranpb Sun Haoran (haoranpb) commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to Pin exact BC container artifact URLs (step 1) #893: resolve the latest public BC artifact once per dataset version, then use that exact candidate in every bug-fix verification matrix job.
  • Only after a full successful scheduled run on main, push a pins-only branch if the verified URLs differ from the saved pins; failed and partial runs retain the existing pins. BC Insider URLs are unchanged.
  • A PR for the branch must be created manually and undergo the required code-owner review. The workflow neither opens a PR nor requests auto-merge; repository rules prevent a direct update to main.

Notes

@haoranpb
Sun Haoran (haoranpb) added this pull request to stack #895 September 25, 2026 06:26
@haoranpb
Sun Haoran (haoranpb) force-pushed the artifact/refresh-bc-container-urls branch from 3527202 to 3513e34 Compare September 25, 2026 07:34
Base automatically changed from artifact/pin-bc-container-urls to main September 25, 2026 08:24
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@haoranpb
Sun Haoran (haoranpb) force-pushed the artifact/refresh-bc-container-urls branch from 3513e34 to 22b986e Compare September 25, 2026 08:24
@haoranpb

Copy link
Copy Markdown
Collaborator Author

Copilot this PR should follow the design of the previous #893

The part about take the stored artifact URLs is completed, now focus on leveraging the weekly run workflow to refresh them

Keep the code changes simple and small

Copilot AI and others added 2 commits September 25, 2026 10:27
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>

Copilot AI commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Copilot this PR should follow the design of the previous #893

The part about take the stored artifact URLs is completed, now focus on leveraging the weekly run workflow to refresh the...

Addressed in 42a3e94. The PR now preserves #893’s hardcoded pin design and changes only the weekly dataset workflow: it resolves refreshed pins once, verifies that exact content across the full matrix, and proposes the verified update afterward.

@haoranpb
Sun Haoran (haoranpb) marked this pull request as ready for review September 29, 2026 12:43
Copilot AI balanced review requested due to automatic review settings September 29, 2026 12:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Promotion tests are missing and the implemented manual-PR flow contradicts the PR description.

Review effort: Balanced
Findings: 3 Low severity

Open (3)
What changed in this PR

Moves public BC artifact pins into configuration and adds scheduled refresh verification.

Changes:

  • Resolves and verifies latest public artifact URLs.
  • Promotes successful results to a branch for manual PR creation.
  • Documents the refresh process.
File Description
scripts/​BCBenchUtils.psm1 Loads and refreshes artifact pins.
scripts/​BCBenchArtifactPins.json Stores pinned URLs.
.github/​workflows/​dataset-validation.yml Verifies and proposes refreshed pins.
CONTRIBUTING.md Documents artifact refresh behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/dataset-validation.yml
Comment thread .github/workflows/dataset-validation.yml
Comment thread CONTRIBUTING.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@haoranpb
Sun Haoran (haoranpb) merged commit bb7f00d into main Sep 30, 2026
16 checks passed
@haoranpb
Sun Haoran (haoranpb) deleted the artifact/refresh-bc-container-urls branch September 30, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants