Broadening argument type for load_configuration_from_env

[Rodrigo Brandão (rodrigobr-msft)]

This pull request refines the load_configuration_from_env function to improve type safety and avoid potential side effects when handling environment variables. The most important changes are:

Type safety and immutability improvements:

• Changed the type annotation for the env_vars parameter in load_configuration_from_env from dict[str, Any] to Mapping[str, Any], allowing for more flexible and type-safe usage.
• Replaced the use of env_vars.copy() with copy(env_vars) to create a shallow copy, ensuring that the original mapping is not mutated and supporting non-dict mappings.
• Renamed the local variable from vars to local_vars for clarity and to avoid shadowing the built-in vars() function.

[Copilot]

Pull request overview

This PR updates load_configuration_from_env in the Activity library to accept broader mapping types for environment-variable parsing, aiming to improve type-safety and reduce unintended side effects when handling env var sources.

Changes:

• Broadened env_vars parameter type from dict[str, Any] to Mapping[str, Any].
• Avoided the local name vars (which shadows the built-in vars()).
• Switched from env_vars.copy() to copy(env_vars) to support non-dict mappings.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

libraries/microsoft-agents-activity/microsoft_agents/activity/config/_load_configuration.py:9

• The return type is still an unparameterized dict, which limits the type-safety improvements from widening env_vars to Mapping[str, Any]. This codebase commonly uses parameterized dict return types (e.g., microsoft_agents/activity/channel_account.py:37 returns dict[str, Any]).

def load_configuration_from_env(env_vars: Mapping[str, Any]) -> dict:

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.